window 8 signs me into a temporary profile where i cannot access my files and any changes i make are deleted when i sign out...however i searched for the issue online and found the solution that i should create a new user and transfer my files to it so i tried it and it worked but after a few days the issue came back again ... sometimes it is solved by signing out then in again but sometimes it is not solved ...

Usually when temp profile is loaded, it would create a new registry key. The new profile registry key would look like same as original profile key, but the original profile key would have .bak at the end.

Basically you need to remove the .bak from original correct profile key and rename the new temp key. Restarting the Windows 8 or 8.1 computer after modifying registry probably will bring back your old profile with your customized desktop and icons.

Steps to remove the .bak registry key.

REGISTRY DISCLAIMER:

Modifying REGISTRY settings incorrectly can cause serious problems that may prevent your computer from booting properly. Microsoft cannot guarantee that any problems resulting from the configuring of REGISTRY settings can be solved. Modifications of these settings are at your own risk.

a. Press Windows Key+ R, type Regedit and hit Enter.
b. Navigate the following location.

Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\WindowsNT\CurrentVersion\ProfileList


c. The key with .bak is for the correct old profile. Currently your Windows computer logged in with fresh (temporary) profile with same key. So, rename the new profile key ( which is not having.bak) and remove .bak from correct profile key.

Log off and log in (or restart) with your user name and password. Check if you get your correct profile with icons and profile settings back in Windows.

Still if Windows loads with temporary profile and creates a registry key with .bak, that means user profile is corrupted and Windows is not reading it properly.